master #3
master #3
Conversation
test.cloneReadableStream.ts
Outdated
| readClone1.pipe(writeStream1); | ||
| readClone2.pipe(writeStream2); | ||
|
|
||
| console.log('File test.txt was copied - OK.'); |
There was a problem hiding this comment.
I would like to stick to dash-case while naming the files and name the test files as clone-readable-stream.spec.ts
Also could we have a separate test folder for all the test files?
cloneReadableStream.ts
Outdated
| _read() {} | ||
| } | ||
|
|
||
| module.exports = ReadableStreamClone; |
There was a problem hiding this comment.
dash-case for file names please
| "singleQuote": true, | ||
| "printWidth": 120, | ||
| "tabWidth": 2 | ||
| } |
There was a problem hiding this comment.
can we use "useTabs": true instead of spaces, please
There was a problem hiding this comment.
I'm push new commit, please - see :)
First of all, I would like to express my gratitude to you for your wonderful package. This is my first PR - so I apologize for any possible mistakes :) Your package works great on Node 14LTS, so there are no problems to solve. But: the documentation says: "Usage of util.inherits () is discouraged. Please use the ES6 class and extends keywords to get language level inheritance support." Actually, only for this reason, I decided to use ES6 syntax and rewrite the code a little. |
add cloneReadableStream.ts with new ES6 typescript syntax for Node 14 and 15